fix: events index: record processed epochs and tipsets for events and eth_get_log blocks till requested tipset has been indexed #12080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All checks have passed |
rvagg
reviewed
Jun 13, 2024
aarshkshah1992
changed the title
rvagg
reviewed
Jun 17, 2024
rvagg
reviewed
Jun 17, 2024
rvagg
reviewed
Jun 17, 2024
rvagg
reviewed
Jun 17, 2024
rvagg
reviewed
Jun 17, 2024
rvagg
reviewed
Jun 17, 2024
rvagg
reviewed
Jun 17, 2024
rvagg
reviewed
Jun 17, 2024
rvagg
reviewed
Jun 17, 2024
rvagg
reviewed
Jun 17, 2024
rvagg
reviewed
Jun 17, 2024
rvagg
approved these changes
Jun 17, 2024
There was a problem hiding this comment.
I think this looks ok, but it's slightly risky so I'd be more comfortable having someone else look too, @Stebalien if available would be good
|
@rvagg Would love a review from @Stebalien too but which part do you find risky ? |
Stebalien
reviewed
Jun 18, 2024
|
FYI, #12111 |
|
@Stebalien I have addressed all your review comments. Except for #12080 (comment) which I would like to address as part of the refactor in #12116 because that really fixes this in a clean way rather than patching the current broken dual write/dual read mechanism we have for ( |
|
@rvagg @Stebalien I'd like to merge this. Based on an offline conversation with @Stebalien -> he agrees this is good to go in it's current form as it does fix the missing event issue with We will prioritise #12116 next. |
rvagg
reviewed
Jun 20, 2024
rvagg
reviewed
Jun 20, 2024
rvagg
reviewed
Jun 20, 2024
rvagg
reviewed
Jun 20, 2024
rvagg
reviewed
Jun 20, 2024
rvagg
reviewed
Jun 20, 2024
Co-authored-by: Rod Vagg <rod@vagg.org>
rvagg
approved these changes
Jun 20, 2024
7 tasks
18 tasks
rvagg
added a commit
that referenced
this pull request
Jun 27, 2024
… eth_get_log blocks till requested tipset has been indexed (#12080) * record seen event epochs * create correct index * migrate to version 6 * fix typo * test both conditions * changes as per review * record reverted tipsets * see if tipsets has events and has not been reverted * sub/unsub tipset updates from the index * eth_get_logs should wait for events * fix naming * changes as per review * solve issue with missing events * use correct var * changes as per review * add unique constraint * fix test wait * check for events at min_height as well * Apply suggestions from code review Co-authored-by: Rod Vagg <rod@vagg.org> * reduce duplication --------- Co-authored-by: Rod Vagg <rod@vagg.org>
Merged
rvagg
added a commit
that referenced
this pull request
Jul 10, 2024
… eth_get_log blocks till requested tipset has been indexed (#12080) * record seen event epochs * create correct index * migrate to version 6 * fix typo * test both conditions * changes as per review * record reverted tipsets * see if tipsets has events and has not been reverted * sub/unsub tipset updates from the index * eth_get_logs should wait for events * fix naming * changes as per review * solve issue with missing events * use correct var * changes as per review * add unique constraint * fix test wait * check for events at min_height as well * Apply suggestions from code review Co-authored-by: Rod Vagg <rod@vagg.org> * reduce duplication --------- Co-authored-by: Rod Vagg <rod@vagg.org>
rvagg
added a commit
that referenced
this pull request
Jul 10, 2024
… eth_get_log blocks till requested tipset has been indexed (#12080) * record seen event epochs * create correct index * migrate to version 6 * fix typo * test both conditions * changes as per review * record reverted tipsets * see if tipsets has events and has not been reverted * sub/unsub tipset updates from the index * eth_get_logs should wait for events * fix naming * changes as per review * solve issue with missing events * use correct var * changes as per review * add unique constraint * fix test wait * check for events at min_height as well * Apply suggestions from code review Co-authored-by: Rod Vagg <rod@vagg.org> * reduce duplication --------- Co-authored-by: Rod Vagg <rod@vagg.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11640 and #12078